Remove disabling of warnings on OSX #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the underlying project to control compile-time warnings instead of silencing them unconditionally.
|
This is absolutely necessary. The fact that's on there for gyp is a bizarre and objectively incorrect flag - I would say it's really a bug, especially since it interferes with other overrides. Please, please merge this. |
|
Ok, consider me convinced. I'll try to get it landed in a new major release later today. It gets a major version because it is a breaking change. |
|
Sounds great @unbornchikken, thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the underlying project to control compile-time
warnings instead of silencing them unconditionally.
See issue #132