Test output instead of guessing by platform #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have Windows Server 2012
node v7.5.0 (x64)
cmake 3.8.0-rc1 (x64)
build tools installed with 'npm install -g windows-build-tools'
The output received at line 73 in this windows platform has only \n in the buffer.
If you test for 'if stdout.includes('\r\n')' then you can handle it based on what was given, instead of assuming a platform is going to be a certain way.
This was causing
ERR! OMG There is no Visual C++ compiler installed. Install Visual C++ Build Toolset or Visual Studio.
ERR! OMG There is no Visual C++ compiler installed. Install Visual C++ Build Toolset or Visual Studio.
I tracked it back to _getTopSupportedVisualStudioGenerator had a list that was empty ... [] ...
and that's because of the parsing error.