Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOTLK] Log File for SD2-Errors Patch #1561

Closed
NeatElves opened this issue Feb 15, 2018 · 3 comments
Closed

[WOTLK] Log File for SD2-Errors Patch #1561

NeatElves opened this issue Feb 15, 2018 · 3 comments
Labels
Expansion: WotLK (3.3.5) Issues relating to the WotLK Expansion (3.3.5). Info: Needs Testing Development is done, needs testing. Type: User Patch Provided Issue includes Code to Resolve the Issue.

Comments

@NeatElves
Copy link

diff --git a/src/shared/Log.cpp b/src/shared/Log.cpp
index 3a6b201f1..85c44edb9 100644
--- a/src/shared/Log.cpp
+++ b/src/shared/Log.cpp
@@ -264,6 +264,7 @@ void Log::Initialize()
     charLogfile = openLogFile("CharLogFile", "CharLogTimestamp", "a");
     dberLogfile = openLogFile("DBErrorLogFile", nullptr, "a");
     eventAiErLogfile = openLogFile("EventAIErrorLogFile", nullptr, "a");
+    scriptErrLogFile = openLogFile("SD2ErrorLogFile", nullptr, "a");
     raLogfile = openLogFile("RaLogFile", nullptr, "a");
     worldLogfile = openLogFile("WorldLogFile", "WorldLogTimestamp", "a");
     customLogFile = openLogFile("CustomLogFile", nullptr, "a");
@killerwife
Copy link

Its done here: void Log::setScriptLibraryErrorFile(char const* fname, char const* libName)
so maybe we need to change that since its in core now?

@NeatElves
Copy link
Author

It is desirable to remake SD2Errors.log and combine with the EventAIErrors.log - for example AIErrors.log output errors in one file.

p.s. Now, you can already see:

2018-02-15 20:04:01 Script requested creature with entry 9564, but no npc of this entry was created yet, or it was not stored by script for map 1.
2018-02-15 20:04:07 Script requested creature with entry 3149, but no npc of this entry was created yet, or it was not stored by script for map 0.
2018-02-15 20:04:13 Script requested creature with entry 12137, but no npc of this entry was created yet, or it was not stored by script for map 0.

@keyshuwen
Copy link

Yes, TBC is the same problem.

@jimmybrancaccio jimmybrancaccio changed the title [Wotlk][Patch] Log File for SD2-Errors [WOTLK] Log File for SD2-Errors Patch Nov 17, 2018
@jimmybrancaccio jimmybrancaccio added Expansion: WotLK (3.3.5) Issues relating to the WotLK Expansion (3.3.5). Type: User Patch Provided Issue includes Code to Resolve the Issue. labels Nov 17, 2018
@jimmybrancaccio jimmybrancaccio added the Info: Needs Testing Development is done, needs testing. label Jun 9, 2019
BadgerBoy81 pushed a commit to BadgerBoy81/mangos-wotlk that referenced this issue Jan 8, 2022
Warlockbugs pushed a commit to cmangos/mangos-classic that referenced this issue Dec 27, 2022
Warlockbugs pushed a commit to cmangos/mangos-tbc that referenced this issue Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expansion: WotLK (3.3.5) Issues relating to the WotLK Expansion (3.3.5). Info: Needs Testing Development is done, needs testing. Type: User Patch Provided Issue includes Code to Resolve the Issue.
Projects
None yet
Development

No branches or pull requests

4 participants