Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TBC] Reconnecting via Grace Period During Taxi Flight Causes Flight Movement Flag to Persist on a Character #1728

Closed
datchannin opened this issue Oct 10, 2018 · 4 comments
Closed

[TBC] Reconnecting via Grace Period During Taxi Flight Causes Flight Movement Flag to Persist on a Character #1728

datchannin opened this issue Oct 10, 2018 · 4 comments
Assignees
@Warlockbugs
Labels
Expansion: TBC (2.4.3) Issues relating to the TBC Expansion (2.4.3).

Comments

@datchannin
Copy link

datchannin commented Oct 10, 2018 •
edited

Current behavior:
Strange issue - run wow in window mode, after - fly using taxi. Minimize window, when remind 1 minute before flying will be finished. Close window with game. After, log in one more time. And wait finishing of your flying. After it finish, you can fly without mount, only by press "space" key.

This is video, how do it. You can scroll time of flying, but look how to close game and start it again.
https://radikal.ru/video/BQ7FST24h7V

Character on the video is without Game Master access.

Expected behavior:
Should not fly without mount and without GM access.

Steps to reproduce:

  1. run wow in window mode
  2. open taxi point in Morgan's Vigil
  3. open taxi point in Thorium Point
  4. start flying from Morgan's Vigil to Thorium Point
  5. minimize window when 60-50 seconds before finish
  6. close window
  7. log in again and wait for finishing of flying
  8. press space key after landing.

Client version:
2.4.3
Commit hash:
latest
Database version:
~04 october
Operating system:
win64
@Warlockbugs
Copy link
Member

Caused by new grace period feature. Exact cause is unknown, but it has something to do with the way we sync splines (client thinks that flight flag is a permanent one instead temporary spline).

@Warlockbugs Warlockbugs changed the title [TBC] You can fly without mount after close window in windowing mode client [TBC] Reconnect via grace period during taxi flight causes flight movement flag to persist on a character Oct 11, 2018
@SilvioDoMine
Copy link

@cyberium

@jimmybrancaccio jimmybrancaccio added the Expansion: TBC (2.4.3) Issues relating to the TBC Expansion (2.4.3). label Nov 17, 2018
@datchannin
Copy link
Author

Found the same issue if player was summoned during taxi. Player can fly without mount after summon. (the latest release)

@jimmybrancaccio jimmybrancaccio changed the title [TBC] Reconnect via grace period during taxi flight causes flight movement flag to persist on a character [TBC] Reconnecting via Grace Period During Taxi Flight Causes Flight Movement Flag to Persist on a Character Nov 24, 2018
@AnonXS AnonXS mentioned this issue Jan 1, 2019
Closed
@Warlockbugs Warlockbugs self-assigned this Jan 20, 2019
Warlockbugs added a commit to cmangos/mangos-wotlk that referenced this issue Jan 20, 2019
@Warlockbugs
Revert ancient workaround causing issue with reconnecting
c069009 
Players who reconnect during taxi flight no longer able to free fly on
arrival.

Modern cores no longer include this workaround.

Please, let us know about any visual rough edges related to players who
are logging in mid-air.

Reverts https://github.com/cmangos/mangos-svn/commit/
2695d3e72f39a673e4eb58bc432fbe4af53523cc

Closes cmangos/issues#1728
Closes cmangos/issues#1821
Warlockbugs added a commit to cmangos/mangos-classic that referenced this issue Jan 20, 2019
@Warlockbugs
Revert ancient workaround causing issue with reconnecting
277aa94 
Players who reconnect during taxi flight no longer able to free fly on
arrival.

Modern cores no longer include this workaround.

Please, let us know about any visual rough edges related to players who
are logging in mid-air.

Reverts https://github.com/cmangos/mangos-svn/commit/
2695d3e72f39a673e4eb58bc432fbe4af53523cc

Closes cmangos/issues#1728
Closes cmangos/issues#1821
@Warlockbugs
Copy link
Member

Fixed. More details in commit description.

If you notice any visual glitches with players who login mid-air (for example, relogging on a flying mount), let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Warlockbugs Warlockbugs

Labels
Expansion: TBC (2.4.3) Issues relating to the TBC Expansion (2.4.3).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jimmybrancaccio @Warlockbugs @SilvioDoMine @datchannin