🐛 [Bug Report] Someone elses hard work pays off - Problem with quest

[Szymplo]

Bug Details

Cryo-Engineer Sha'heen shows up correctly. The he goes to first device (ether gatherer or something) the first wave of mobs spawns correctly. After defeating them Sha'heen stands and does nothing. You can't complete quest because he seems be unable to take care of first device.

Steps to Reproduce

1. Make your way to place where quest "Someone elses hard work pays off" starts
2. See that Sha'heen won't proceed with quest after dealing with 1'st wave of enemies

Expected behavior

Quest should work correctly cause now it looks it's impossible to finish it.

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

162cd3f237022e229da6cc976295a607e0a1cc76

Database SHA1 Commit Hash

9cc4fb63c86a908c0d2ac387fdec0d560bff65b1

Operating System

Debian 11 with MariaDB

Client Version

2.4.3 (The Burning Crusade)

[MantisLord]

Confirmed... He gets stuck here:

The escort pauses and never resumes for some reason.
We're also getting errors because he uses DoScriptText with broadcast text entries instead of DoBroadcastText:

DoScriptText with source entry 19671 (TypeId=3, guid=10009140) attempts to process text entry 17229, but text entry must be negative.
DoScriptText with source entry 19671 (TypeId=3, guid=10009140) attempts to process text entry 17249, but text entry must be negative.

Maybe it's possible we can delete the entire npc_shaheen C++ script and redo him in the DB.

[Grz3s]

I could do it...but
question is - if we want to do that
I remember that @xfurry wanted to do all escorts in c++ (prob had a reason for it)
Are there any advantages above dbscripting? @killerwife ?

[xfurry]

I guess that was an old approach to scripting escorting quests.
If it's possible to do it in DB I would go for it

[killerwife]

Proximity check for people on quest for failing is not currently available in db.

[MantisLord]

I think I will keep his C++ script for now and give him creature_spell_list for his combat abilities.

[xfurry]

Issue is probably around this line
https://github.com/cmangos/mangos-wotlk/blob/master/src%2Fgame%2FAI%2FScriptDevAI%2Fscripts%2Foutland%2Fauchindoun%2Fmana_tombs%2Fmana_tombsScripts.cpp#L142

Probably the script does not register the summoned adds which die, hence the movement does not restart.

[miraco]

Issue is probably around this line https://github.com/cmangos/mangos-wotlk/blob/master/src%2Fgame%2FAI%2FScriptDevAI%2Fscripts%2Foutland%2Fauchindoun%2Fmana_tombs%2Fmana_tombsScripts.cpp#L142

Probably the script does not register the summoned adds which die, hence the movement does not restart.

That’s something I noticed when reworking other escort quests, on blizz the escort npcs most of the time don’t wait till the spawned adds are dead to they move on. It’s possible that escort npcs just ignore them and keep moving.