[c13075] Move static data from header file to source file.

1. It's only used in the implementation anyway, so treat it as an implementation detail and don't expose it in the header. 2. It avoids lots of compiler warnings about unused variables in every source file that directly or indirectly includes the header (and there are lots!). (based on commit [12862] - 7b5fdba) Signed-off-by: Xfurry <xfurry@scriptdev2.com>
cmangos · Jul 8, 2015 · f9617de · f9617de
1 parent 7d48dfe
commit f9617de
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/game/GridMap.cpp b/src/game/GridMap.cpp
@@ -36,6 +36,9 @@ char const* MAP_AREA_MAGIC    = "AREA";
 char const* MAP_HEIGHT_MAGIC  = "MHGT";
 char const* MAP_LIQUID_MAGIC  = "MLIQ";
 
+static uint16 holetab_h[4] = { 0x1111, 0x2222, 0x4444, 0x8888 };
+static uint16 holetab_v[4] = { 0x000F, 0x00F0, 0x0F00, 0xF000 };
+
 GridMap::GridMap()
 {
     m_flags = 0;

diff --git a/src/game/GridMap.h b/src/game/GridMap.h
@@ -108,9 +108,6 @@ enum GridMapLiquidStatus
 #define MAP_LIQUID_TYPE_DARK_WATER  0x10
 #define MAP_LIQUID_TYPE_WMO_WATER   0x20
 
-static uint16 holetab_h[4] = { 0x1111, 0x2222, 0x4444, 0x8888 };
-static uint16 holetab_v[4] = { 0x000F, 0x00F0, 0x0F00, 0xF000 };
-
 struct GridMapLiquidData
 {
     uint32 type_flags;

diff --git a/src/shared/revision_nr.h b/src/shared/revision_nr.h
@@ -1,4 +1,4 @@
 #ifndef __REVISION_NR_H__
 #define __REVISION_NR_H__
- #define REVISION_NR "13074"
+ #define REVISION_NR "13075"
 #endif // __REVISION_NR_H__