Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug with URL loading #21

Closed
evilfer opened this issue Jan 16, 2020 · 1 comment
Closed

Possible bug with URL loading #21

evilfer opened this issue Jan 16, 2020 · 1 comment

Comments

@evilfer
Copy link

evilfer commented Jan 16, 2020

Hi,

It looks like there is a possible bug here:

https://github.com/cmap/morpheus.js/blob/master/index.html#L67

I believe that in line 67 (https://github.com/cmap/morpheus.js/blob/master/index.html#L67) the code should use function then, not done. So the code should be:

morpheus.Util.getText(params.url).then(function (text) {

What do you think?

EDIT:

Similarly:

Line 70 should use catch, instead of fail
Line 73 should use finally, instead of always

@joshua-gould
Copy link
Collaborator

Thanks, this is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants