Skip to content

Commit

Permalink
chore: disable cosign for now (#22)
Browse files Browse the repository at this point in the history
fulcio signing seems to have broken, disable cosign until we can set up
signing keys.
  • Loading branch information
cmars committed Aug 25, 2022
1 parent b0324a8 commit 84aaee6
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,16 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}

# Sign the resulting Docker image digest except on PRs.
# This will only write to the public Rekor transparency log when the Docker
# repository is public to avoid leaking data. If you would like to publish
# transparency data even for private images, pass --force to cosign below.
# https://github.com/sigstore/cosign
- name: Sign the published Docker image
if: ${{ github.event_name != 'pull_request' }}
env:
COSIGN_EXPERIMENTAL: "true"
# This step uses the identity token to provision an ephemeral certificate
# against the sigstore community Fulcio instance.
run: cosign sign ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}@${{ steps.build-and-push.outputs.digest }}
# TODO: uncomment when we have a signing key set up, fulcio no longer working
## Sign the resulting Docker image digest except on PRs.
## This will only write to the public Rekor transparency log when the Docker
## repository is public to avoid leaking data. If you would like to publish
## transparency data even for private images, pass --force to cosign below.
## https://github.com/sigstore/cosign
#- name: Sign the published Docker image
# if: ${{ github.event_name != 'pull_request' }}
# env:
# COSIGN_EXPERIMENTAL: "true"
# # This step uses the identity token to provision an ephemeral certificate
# # against the sigstore community Fulcio instance.
# run: cosign sign ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}@${{ steps.build-and-push.outputs.digest }}

0 comments on commit 84aaee6

Please sign in to comment.