Recover from a broken Cn #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Will try to get to this early next week, I've been quite busy. |
|
@cmars are you still working on this pull requests? |
cmars
requested changes
Jun 8, 2018
| @@ -160,6 +160,10 @@ def parse_records(self, count=0): | |||
| if len(fields) < len(recType.columnNames): | |||
| fields += [None] * (len(recType.columnNames) - len(fields)) | |||
| self.send((recType, fields)) | |||
| if header.len > 0: | |||
| print >> sys.stderr, "Warning: Broken header. Unprocessed data left in", recType.__class__.__name__, "record. Working around it." | |||
There was a problem hiding this comment.
This will need to be updated to python 3.
florisla
added a commit
to florisla/pystdf
that referenced
this pull request
Jul 12, 2018
Commit fbab53aa19d1aea43ff3ab2ace15058945f2e49 from cmars#1 ported to Python 3.
|
Replaced by #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around someone else's bug where they write a Cn that is longer than 255 bytes. They actually write the long string but the U1 with the length overflows to some smaller number. Since the parser actually does the read operations, some data from the record is left unread and subsequent reads see garbage.
I think a better approach is to read each record's REC_LEN bytes first and have the parsers work on that data but the parser is very complicated and I wouldn't know where to begin making that change.