Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging update #45

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Packaging update #45

merged 6 commits into from
Aug 18, 2023

Conversation

timlaracy
Copy link
Contributor

@timlaracy timlaracy commented Aug 18, 2023

Hi Casey,

In this PR, I changed the setup.py file over to a pyproject.toml and updated the dependency section.

Additionally, I changed your scripts so they work properly with the new pyproject.toml entry point format (basically changed your "if name == "main":"'s to def main()'s )

to build a wheel, do the following:
python -m pip install build
And then to build the package
python -m build

Once you have your ~/.pypirc file all set up with your PyPI info, to upload you will need a packaged called "twine"
python -m pip install twine
Then, to upload to pypi
python -m twine upload --repository <your_repo_name> dist/*

That should be it. Please reach out with any questions or concerns!

Seems like the scripts themselves are not running... Perhaps that can be addressed in another pull request

Tim

@timlaracy timlaracy marked this pull request as ready for review August 18, 2023 18:34
Copy link
Owner

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thanks for this!

Local build & pip install into a fresh venv worked great! I noticed the script issue, but I was able to import things, and even run the scripts by importing them and setting sys.argv by hand. I'm sure it's a simple fix for a followup.

Publishing after this lands.

@cmars cmars merged commit 4925ec9 into cmars:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants