Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to larger image doesn't work when there is no caption #17

Closed
mapsam opened this issue Jul 9, 2014 · 1 comment
Closed

link to larger image doesn't work when there is no caption #17

mapsam opened this issue Jul 9, 2014 · 1 comment
Labels
Milestone

Comments

@mapsam
Copy link
Contributor

mapsam commented Jul 9, 2014

caption length > 0 is required for all of the linking to work. Should write a quick checker in there something like if(p._caption) { ... }

@mapsam mapsam added the bug label Jul 9, 2014
@mapsam mapsam added this to the 0.0.6 milestone Nov 26, 2014
mapsam added a commit that referenced this issue Nov 26, 2014
@mapsam
Copy link
Contributor Author

mapsam commented Nov 26, 2014

required a check for the params._caption to be set to true, as well as the actual caption in instagram.data[i].caption to not equal null

if(params._caption && instagram.data[id].caption) { ... }

@mapsam mapsam closed this as completed Nov 26, 2014
@mapsam mapsam mentioned this issue Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant