Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging, Python 2/3 support (Noetic), CI, rename package to whole_body_state_msgs #3

Merged
merged 8 commits into from Aug 20, 2020
Merged

Packaging, Python 2/3 support (Noetic), CI, rename package to whole_body_state_msgs #3

merged 8 commits into from Aug 20, 2020

Conversation

wxmerkt
Copy link
Contributor

@wxmerkt wxmerkt commented Aug 19, 2020

A few modifications as discussed

  • Rename to whole_body_state_msgs (or similar, for release later)
  • Add Travis CI for Kinetic, Melodic, Noetic
  • Minor changes to Python packaging
  • Update of dependencies keys

cmastalli
cmastalli reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be everything good, thanks!!!
Just I am not sure why do we need sensor_msgs.

On the other hand, do not forget to add Oxford and in the credits your name.

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@wxmerkt wxmerkt mentioned this pull request Aug 19, 2020
Merged
@cmastalli cmastalli merged commit e119d56 into loco-3d:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmastalli cmastalli cmastalli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wxmerkt @cmastalli