Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET requests error #15

Closed
alenpesikan opened this issue Dec 12, 2016 · 1 comment
Closed

GET requests error #15

alenpesikan opened this issue Dec 12, 2016 · 1 comment

Comments

@alenpesikan
Copy link

It doesn't work well for GET requests. Only POST & PUT
@cmawhorter
Copy link
Owner

depending on the server and client, sometimes the request body will be evaluated to null or undefined.

likely what's happening is req.body is undefined and being converted to the string "undefined" which is then being used to calculate the compare signature.

i think doing req.body = req.body || ''; prior to hmmac will resolve the issue, but like i said, it depends on the server/client being used.

i'll leave this open. this project isn't dead but has been dormant because it Worked for Me and any issue had a decent workaround.

i'm planning to ship a v1.0 sooner than later

Akkuma pushed a commit to virtru/hmmac that referenced this issue Jul 10, 2017
@nzack @Akkuma
WS-5966 non ascii support (#1)
310ccdb 
* use spdx license to avoid npm warning

* closes cmawhorter#10

* add test for cmawhorter#11

* document cmawhorter#11

* bump version

* update travis badge for current branch

* closes cmawhorter#16

* wip

* fixes cmawhorter#18

* node version support and ci

* closes cmawhorter#15

* req to credProvider cmawhorter#13

* closes cmawhorter#13

* bump version

* 0.2.3

* do not ship

* npm dbl bump

* outdated about

* Updated to ensure utf8 always

* Added tests for non-ascii

* Updated to support inputEncoding

* Modified to support passing in encoding

* Updated version

* Added CHANGELOG

* Added reference to PR

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmawhorter @alenpesikan