Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so the demo notebook launches on MyBinder #93

Closed
fomightez opened this issue Dec 6, 2020 · 1 comment
Closed

Fix so the demo notebook launches on MyBinder #93

fomightez opened this issue Dec 6, 2020 · 1 comment

Comments

@fomightez
Copy link

A user, TSSFL, posted in the Jupyter Discourse forum here seeking help when that they could not launch the CAMB demo notebook via MyBinder.org.

The issue is that there are a couple of ways in which the present Dockerfile in the CAMB repo deviates from the documentation for preparing a Dockerfile and at present this causes the launch to never work.

SOLUTION: A few edits to the Dockerfile were necessary to bring it in line with the directions, as implemented in the fork here. (The Dockerfile specifically is here.) If you use the launch binder badge there, it will use that forked repo as the source and start up. The launched session was verified to be capable of actively running the demo notebook.

I'm not doing this as a Pull Request because I am unsure exactly what image tag you'd specifically like to use in the FROM command in the Dockerfile.

(While you are doing this, you may optionally want to update the launch binder badge to match the newer, better-branded style, as can be seen near the top of the README of the fork here.)

cmbant added a commit that referenced this issue Dec 6, 2020
cmbant added a commit that referenced this issue Dec 6, 2020
@cmbant
Copy link
Owner

cmbant commented Dec 6, 2020

Thanks, merged and seems to work.

@cmbant cmbant closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants