Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an url with the transcript id in it #57

Merged
merged 6 commits into from
Aug 7, 2019
Merged

Conversation

cbaakman
Copy link
Contributor

@cbaakman cbaakman commented Aug 6, 2019

Adds an url: ..../metadome/transcript/id/. Where 'id' is the transcript id. The page will retrieve the visualization data for this transcript and show it when ready.

Inserting a faulty transcript id will result in feedback.

Copy link
Member

@laurensvdwiel laurensvdwiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Coos, could you please check these comments?

metadome/presentation/web/routes.py Outdated Show resolved Hide resolved
metadome/presentation/web/templates/dashboard.html Outdated Show resolved Hide resolved
metadome/presentation/web/templates/dashboard.html Outdated Show resolved Hide resolved
@laurensvdwiel
Copy link
Member

Two things don't work yet:
http://localhost:5000/metadome/dashboard/transcript/test/
-> no error atm (I think there was one previously)

http://localhost:5000/metadome/dashboard/transcript/ (e.g. empty)
-> Error page, perhaps a redirect to '/metadome/dashboard/' is preferred here?

@cbaakman
Copy link
Contributor Author

cbaakman commented Aug 7, 2019

You're right! I forgot to check the error page.

@laurensvdwiel
Copy link
Member

Thanks a lot Coos. This is great, you are the best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants