Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor\msysgit\libexec\git-core dir contains 1.45mb git.exe duplicated 110 times. #54

Closed
SchizoDuckie opened this issue Nov 28, 2013 · 15 comments · Fixed by #85 or #450
Closed

vendor\msysgit\libexec\git-core dir contains 1.45mb git.exe duplicated 110 times. #54

SchizoDuckie opened this issue Nov 28, 2013 · 15 comments · Fixed by #85 or #450
Labels
👆 Git Upstream issue in Git for Windows.
Milestone

Comments

@SchizoDuckie
Copy link

This is why your download is 250mb zipped. Please fix this by creating symlinks or .bat files

(Removed the list so I do not have to scroll like crazy)

@samvasko
Copy link
Contributor

:rage2: Oh man, why the hell...

@samvasko
Copy link
Contributor

relevant issue msysgit/msysgit#58

@samvasko
Copy link
Contributor

This looks like more complex than just removing

@MartiUK
Copy link
Member

MartiUK commented Dec 9, 2013

There are also some perl scripts in that folder that only work with the git.exe for example:

131209131935

Symlinks may work but will require UAC (This will be a pain for enterprise users), I suggest the batch file method.

I've got a local copy with most of them recreated as batchfiles and a setup script.

I'll send a pull request when it's done.

@samvasko
Copy link
Contributor

samvasko commented Dec 9, 2013

Integrating it into build/pack script it would be great!

@MartiUK
Copy link
Member

MartiUK commented Dec 10, 2013

@Bliker Will try my best, I'm more of a python guy myself.

@samvasko
Copy link
Contributor

I can port it if it is a trouble. The language bar is diverse already. :D

@samvasko samvasko reopened this Jan 2, 2014
@samvasko
Copy link
Contributor

samvasko commented Jan 2, 2014

The script is not working very well. Not at all I should say.

@MartiUK
Copy link
Member

MartiUK commented Jan 2, 2014

@Bliker Yes, I was wondering why you merged it, I have some more commits to pull, but very busy.

@samvasko
Copy link
Contributor

samvasko commented Jan 2, 2014

Well I wanted to work on it myself and I just about finished it. Check the git-cleanup branch. I had to dig bit into git source and use checksums to find the duplicates.

@MartiUK
Copy link
Member

MartiUK commented Jan 3, 2014

Most of them (the duplicates) do not work for me anyway, especially the
perl scripts.
On 2 Jan 2014 23:59, "Samuel Vasko" notifications@github.com wrote:

Well I wanted to work on it myself and I just about finished it. Check the
git-cleanup branch. I had to dig bit into git source and use checksums to
find the duplicates.


Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-31495836
.

@SamHasler
Copy link

Would it be possible to have a setup option to remove these files for users that never use the git-* format?

@samvasko
Copy link
Contributor

samvasko commented Jan 8, 2014

I think no. Some of the perl/sh scripts still use the dashed version.

@cartel0x27
Copy link

Looks like this is still an issue. You could look into using links on Windows (mklink.exe) instead of 110 copies of a .exe file.

@cartel0x27
Copy link

Fixed for me, when run from the libexec folder:

@echo off
dir /s git-*.exe | find "1,479,680" > fixexes.txt
for /F %%f IN ( fixexes.txt ) DO (
 @echo Processing %%f
 del %%f
 mklink  %%f git.exe
)
del fixexes.txt

I'd say this is to do with just zipping the files from msysgit. Zip files dont capture the fact that they were hard linked to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Git Upstream issue in Git for Windows.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants