Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /x "CONEMU ARGS" command line argument. #2096

Merged
merged 2 commits into from May 22, 2019

Conversation

eziosella
Copy link
Contributor

This argument forwards parameters to ConEmu app.

e.g. Cmder.exe /FWPARS "-min -tsa"

In this case Cmder will start minimized on TaskBar

This argument forwards parameters to ConEmu app.

	e.g. Cmder.exe /FWPARS "-min -tsa"

In this case Cmder will start minimized on TaskBar
@daxgames
Copy link
Member

daxgames commented May 12, 2019

Thanks for the PR, I have not looked yet but will look later today when i get home. Initial thoughts and questions:

  1. Is the arg case sensitive? Hopefully not.

Just looked, no it is not.

  1. Did you update the command line help?

Yes.

  1. Did you update the README.md with documentation.

Yes

  1. Can you make the arg /conemu-args, seems more intuitive.

The issue I forsee is what if a conemu arg needs to be quoted. The approach I was looking at was just to compile all unknown args and pass them to conemu directly . This would avoid the quoted arg issue. I am having difficulty in figuring this out though due to data type diffs.

Copy link
Member

@daxgames daxgames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have compiled and tested it here.

Please change the parameter to /conemu-args so it is more intuitive and add to the Unreleased section of the CHANGELOG.md usint the same format that is used there.

@eziosella
Copy link
Contributor Author

eziosella commented May 12, 2019 via email

@eziosella
Copy link
Contributor Author

eziosella commented May 12, 2019 via email

@daxgames
Copy link
Member

@eziosella I hope I did not discourage your participation by asking for changes. You still working on this? Or did you decide to tackle the quoting question I raised or maybe the forward all unknown args direct to conemu?

You could just make this argument be /x. It's short, could mean 'extra parameters'. I've been thinking about it and /fwpars and /conemu-args are just too long.

@eziosella
Copy link
Contributor Author

@daxgames No discouraged, just been busy.

About the /x argument it is definitely better. I already had modified (not pushed yet) with /conemu-args but i will change for the shorter way.

@daxgames daxgames changed the title Add FWPARS cmdline argument. Add /x "CONEMU ARGS" command line argument. May 22, 2019
@daxgames daxgames changed the title Add /x "CONEMU ARGS" command line argument. Add /x "CONEMU ARGS" command line argument. May 22, 2019
@daxgames daxgames merged commit 4510abb into cmderdev:master May 22, 2019
@daxgames
Copy link
Member

@eziosella MERGED. Thanks again for the PR and the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants