Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the render work with older f# #8

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Conversation

davidtme
Copy link
Contributor

When using FSharp.Compiler.Tools you do not have access to:

  • opening of static classes
  • member _. - this is throwing an error but I can't find the documentation when this was added - quite hard to search for

this just add GeneratedCodeUtils to the functions and replace _. with this.

Remove `member _.` as this doesn't work in older f#
@cmeeren
Copy link
Owner

cmeeren commented Feb 11, 2021

There is no opening of static classes in generated code. I don't think this change is needed.

Instead of this., you can use __. (double underscore). That works for older F#, and still signifies that it should be ignored.

@cmeeren
Copy link
Owner

cmeeren commented Feb 11, 2021

I can't find the documentation when this was added - quite hard to search for

Not sure what you're after here.

@davidtme
Copy link
Contributor Author

@cmeeren sorry, I think the _ problem was thrown me off and making me thinking it was a static class

@cmeeren cmeeren merged commit 955aa5c into cmeeren:master Feb 11, 2021
@cmeeren
Copy link
Owner

cmeeren commented Feb 11, 2021

Released in v0.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants