Fix query with lots of nullable columns creating stack overflow #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeeren
reviewed
Feb 15, 2021
Split out read
davidtme
changed the title
cmeeren
reviewed
Feb 15, 2021
src/DbTests/SQL/ManyColumns.sql
Outdated
| @@ -0,0 +1,601 @@ | |||
| SELECT | |||
There was a problem hiding this comment.
Could you replace this script with the following, which does the same in a lot fewer lines?
DECLARE @numCols INT = 600
DECLARE @sql NVARCHAR(MAX) = 'SELECT '
DECLARE @colNo INT = 1
WHILE (@colNo <= @numCols)
BEGIN
SET @sql += 'Column' + CAST(@colNo AS NVARCHAR) + ' = NULL' + CASE @colNo WHEN @numCols THEN '' ELSE ', ' END
SET @colNo += 1
END
EXEC sp_executesql @sql
src/DbTests/facil.yaml
Outdated
| @@ -192,6 +192,8 @@ rulesets: | |||
| tvp: | |||
| type: dbo.SingleColNonNull | |||
|
|
|||
| - for: ManyColumns.sql | |||
There was a problem hiding this comment.
Empty for has no effect, this can be removed.
src/Facil.Generator/Render.fs
Outdated
| yield! indent [ | ||
| for c in cols do | ||
| if c.IsNullable then | ||
| $"let ``value_{c.Name.Value}`` = if reader.IsDBNull ``ordinal_{c.Name.Value}`` then {outOptionNone} else reader.{c.TypeInfo.SqlDataReaderGetMethodName} ``ordinal_{c.Name.Value}`` |> {outOptionSome}" |
There was a problem hiding this comment.
Is there any point to prefixing with value_? If not, I suggest removing the prefix.
There was a problem hiding this comment.
value_ has been removed
|
I think there could be some other places |
davidtme
changed the title
|
@cmeeren I have run the code gen on my project that was throwing the stack overflow and it now works :) |
davidtme
changed the title
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for #9