Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deploy-git-hook to puppet-deploy-git-hooks #6

Closed
wants to merge 1 commit into from

Conversation

pabs3
Copy link

@pabs3 pabs3 commented May 14, 2020

deploy-git-hook is a very generic name and
doesn't include the word puppet.

This makes this project easier to include in distributions.

deploy-git-hook is a very generic name and
doesn't include the word puppet.

This makes this project easier to include in distributions.
@cmeissner
Copy link
Member

The repository already named puppet-git-hooks so deploy-git-hooks is a good choice.

@pabs3
Copy link
Author

pabs3 commented May 14, 2020 via email

@cmeissner
Copy link
Member

I understand you intention but as you also say you can simply rename the script while building the package. Just add a line to the rule or make file you use to create the package.
This repo was intended to install git hooks in a puppet control repo. Feel free to use it in your package but I see no need of renaming the file.

@cmeissner cmeissner closed this May 15, 2020
@pabs3 pabs3 deleted the less-generic-naming branch May 17, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants