-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #4
Add tests #4
Conversation
delete wrap/unwrap use mdanalysis instead move amber dict conversion is more general delete unused functions
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
===========================================
+ Coverage 12.62% 97.61% +84.98%
===========================================
Files 3 4 +1
Lines 578 168 -410
===========================================
+ Hits 73 164 +91
+ Misses 505 4 -501
|
Looks good to me. There are a couple of things I have questions about, or think might warrant a change.
|
great point! the mapping operators are not what I want them to be yet. 🤔 Basically I want a CG_Compound to be able to be created using SMARTS or a mapping operator. The mapping operator would be solely based on particle indices and would be saved as an attribute to the CG_Compound when the compound is created from SMARTS. Allowing a CG_Compound to be created from a mapping operator would be helpful for using it on simulation outputs that are not in optimal conformations. e.g., We can get the mapping from the initial frame (ideal positions--recognizable to smarts matching) using smarts and use the mapping on the last frame (maybe weird conformation). Another update I want to make is that we keep track of the anchors and bonds in the CG_Compound as they’re created so that no mapping is necessary to the backmap function. For instance, the only arg to backmap would be the CG compound!
I agree and I will make that change. I think finegrain and coarsegrain is maybe the most understandable. |
fixes #1 #2
before merging