Fix sending emails with MailKit #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
changed the title
While sending messages using MailKit/MimeKit, the last two charecters of the body were being "cut" due to the way the new line character was being removed from the raw message.
joaopgrassi
force-pushed
the
bug/26_mimekit_incompletebody
branch
from
4a3fd7e
to
9099019
Compare
cmendible
requested changes
Feb 26, 2020
|
@cmendible okay. I was also thinking on adding a build for other platforms as well. What do you think? Also, the tests seem to randomly fail.. I was wondering if it's due to my test creating a new server? Would it help if I use |
|
Ok we can create a new issue for the new builds. And yes please change your test to use another port to avoid issues. |
|
@joaopgrassi thanks for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26