An enhanced/updated PR of #210 to fix messenger between scope in issue #209

[AbdullahFaqeir]

Issue Reference

#209

Description

between() scope behaves incorrectly, when asking to return the only thread between users (1, 2), it returns all the conversations which both of those users participate in.

So now, between() scope, keeps it's incorrect behaviour, yet now it's not incorrect for the case it's now supposed to do, which is returning any threads which the passed participants are in, but added a new betweenOnly() scope, which will only return the thread of which the passed participants are in.

Note : check test cases to understand more what happened.

How To Test This?

Run unit testing

Documentation

• Added scope betweenOnly() to get private conversations between only passed participants.
• Added test case for betweenOnly() scope.
• Code refactor.
• Fix typos.

[AbdullahFaqeir]

@cmgmyr can you please review this PR?

[AbdullahFaqeir]

@cmgmyr I'm sorry for the nag ^^', but I need this package, if you can check the PR.

[cmgmyr]

@AbdullahFaqeir thank you for the contribution!

This looks good to me so far. Can you tell me if you tested this with PostgreSQL? I remember having issues with the query in my original PR. Ideally, we'd be able to support all of the drivers in Laravel.

[AbdullahFaqeir]

@cmgmyr I haven't actually test it on PostgreSQL, I'll do so and update you.

[AbdullahFaqeir]

Hey @cmgmyr!

Well, finally this is solved once and for all.

According to (this )[https://www.postgresqltutorial.com/postgresql-having/]

laravel-messenger/src/Models/Thread.php

Lines 206 to 214 in 9d6b544

	public function scopeBetween(Builder $query, array $participants)
	{
	return $query->whereHas('participants', function (Builder $q) use ($participants) {
	$q->whereIn('user_id', $participants)
	->select($this->getConnection()->raw('DISTINCT(thread_id)'))
	->groupBy('thread_id')
	->havingRaw('COUNT(thread_id)=' . count($participants));
	});
	}

The way old between() scope was written in a way PostgreSQL won't be able to execute according to the cycle of evaluation of the SQL statement, as you can see, in the link above, the HAVING can't have access to aliases, as well column used in it must be used in the group clause.

After rewriting the SQL statement in the most generic way, I managed to make it work on PostgreSQL as well.

Tested, but couldn't commit the testing updates as they were really messed up; Tests configuration needs to be restructured in a proper way.

I believe this is ready to be merged now.

[cmgmyr]

@AbdullahFaqeir I updated the test suite to use GitHub actions as well as some other updates. Can you rebase/update and re-push your work? This should now catch any issues with MySQL and Postgres. Please let me know if you need any assistance.

[cmgmyr]

Perfect! I thought I saw those tests before - thanks for adding those back in and thanks so much for this PR! It's great to have this finally cleaned up!

I'll go ahead and merge this, but will wait to tag until next week. In the meantime, composer can be updated to reference dev-master for additional testing