Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update date casting #394

Merged
merged 1 commit into from
Mar 31, 2023
Merged

update date casting #394

merged 1 commit into from
Mar 31, 2023

Conversation

cmgmyr
Copy link
Owner

@cmgmyr cmgmyr commented Mar 31, 2023

This PR updates the model's $dates = [] to use $casts = []. This also drops the reference for the deleted_at field, which is redundant from using the SoftDeletes trait.

Anyone still using this package on Laravel versions 5.8, or under, will have to:

  1. Create their own models
  2. Extend the package models
  3. Re-add the $dates = [...] property
  4. Reference the new models in the config file

Fixes #393

@cmgmyr cmgmyr self-assigned this Mar 31, 2023
@cmgmyr cmgmyr marked this pull request as ready for review March 31, 2023 10:34
@cmgmyr cmgmyr merged commit 368cc3b into master Mar 31, 2023
41 checks passed
@cmgmyr cmgmyr deleted the update-date-casts branch March 31, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participant model last_read property casts MISSING under Laravel 10
1 participant