Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] react example does not work with deno 1.7.5 #105

Closed
bpevs opened this issue Mar 1, 2021 · 1 comment · Fixed by #106
Closed

[BUG] react example does not work with deno 1.7.5 #105

bpevs opened this issue Mar 1, 2021 · 1 comment · Fixed by #106
Labels
bug Something isn't working examples

Comments

@bpevs
Copy link
Contributor

bpevs commented Mar 1, 2021

Issue

Setup:

  • Deno Version: deno 1.7.5
  • v8 Version: 9.0.123
  • Typescript Version: 4.1.4
  • Opine Version: 1.1.0

Details

react example looks to be broken with latest Deno.

Primarily, this is caused by breaking change where Deno.bundle is deprecated in favor of Deno.emit.
Also, I needed to bump dejs (I bumped to dejs@0.9.3) to get it working.

I have fix working locally if you'd like me to submit a pr.

Also, was wondering, if this is supposed to be an example, does it make sense to use full opine urls instead of local ref?
ala: import { opine, serveStatic } from "https://deno.land/x/opine@1.1.0/mod.ts";
instead of: import { opine, serveStatic } from "../../mod.ts";

@asos-craigmorten
Copy link
Collaborator

Hey @ivebencrazy! 👋

All sounds very good - we should indeed be using Deno.emit() now instead of Deno.bundle()!

If you have a fix on the go then a PR would be very welcome! 😄 🎉

R.E. the examples it's a good point - I guess to be good "lift and shift" / "copy and paste" material for getting started then really we should use the full urls - if that's something you'd be open to putting into / adding to a PR that would be awesome as well 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants