Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#156] Replace deprecated Deno.readAll #157

Merged
merged 6 commits into from
Feb 20, 2022
Merged

Conversation

fucksophie
Copy link
Contributor

Issue

Fixes #156

Details

Remove deprecated API Deno.readAll with appropriate replacement

CheckList

  • PR starts with [#ISSUE_ID].
  • Has been tested (where required).

@cmorten
Copy link
Owner

cmorten commented Feb 20, 2022

Nice catch @yourfriendoss - looks like just needs a make fmt to appease the formatter

@cmorten cmorten changed the title Fixes issue #156 [#156] Replace deprecated Deno.readAll Feb 20, 2022
@fucksophie
Copy link
Contributor Author

fucksophie commented Feb 20, 2022

Formatted! The version should be probably bumped up by one patch too, no?

@github-actions
Copy link

Benchmark results

PR to merge main ffe9f29 -> main
opine: 1 middleware
================================

1 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.21ms  584.25us  16.59ms   89.22%
    Req/Sec     2.27k   302.29     2.55k    86.67%
  Latency Distribution
     50%    2.05ms
     75%    2.30ms
     90%    2.72ms
     99%    4.17ms
  13576 requests in 3.01s, 2.45MB read
Requests/sec:   4513.00
Transfer/sec:    832.97KB

opine: 10 middleware
================================

10 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.17ms  547.67us  16.62ms   91.01%
    Req/Sec     2.31k   294.90     2.53k    87.10%
  Latency Distribution
     50%    2.03ms
     75%    2.18ms
     90%    2.61ms
     99%    3.91ms
  14289 requests in 3.10s, 2.58MB read
Requests/sec:   4604.91
Transfer/sec:    849.93KB

opine: 50 middleware
================================

50 middleware
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.43ms    0.92ms  28.81ms   92.23%
    Req/Sec     2.08k   355.57     2.38k    83.87%
  Latency Distribution
     50%    2.19ms
     75%    2.49ms
     90%    3.07ms
     99%    5.52ms
  12875 requests in 3.11s, 2.32MB read
Requests/sec:   4142.37
Transfer/sec:    764.56KB

std/http benchmark
================================

Server listening on localhost:3333
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   645.88us  268.82us   7.44ms   94.44%
    Req/Sec     7.69k     0.87k    8.66k    82.81%
  Latency Distribution
     50%  597.00us
     75%  646.00us
     90%  780.00us
     99%    1.51ms
  48991 requests in 3.20s, 4.06MB read
Requests/sec:  15305.12
Transfer/sec:      1.27MB

deno_http_native benchmark
================================

Server listening on localhost:3333
Running 3s test @ http://localhost:3333/?foo[bar]=baz
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   605.62us  141.09us   4.78ms   91.54%
    Req/Sec     8.11k   565.78     8.67k    83.87%
  Latency Distribution
     50%  584.00us
     75%  620.00us
     90%  691.00us
     99%    1.04ms
  50010 requests in 3.10s, 4.15MB read
Requests/sec:  16132.78
Transfer/sec:      1.34MB

@cmorten cmorten merged commit 0674201 into cmorten:main Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON middleware does not work on Deno Deploy
2 participants