(fix) deno 1.4.0 : export type #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsPR to merge main b717cdf -> main |
|
Hey @ThomasT404! 👋🏻 Thanks so much 😄 on my todo list but not got round to it! Look forward to seeing the deps fixed up so we can get this in! |
|
A lot of checks are broken, can anyone fix this merge? |
I just fixed the lock.json file 😄 |
jvmazagao
approved these changes
Sep 14, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
With Deno 1.4.0 a problem prevents the library from being used and makes it necessary to use the "--isolatedModules" entry to work.
Details
I changed all the exports and imports that were types to make it work.
But libraries that Opine uses currently have the same problem, I am also looking at PRs fixes for their libs