feat: 4.7.1

.github/CHANGELOG.md

@@ -1,8 +1,12 @@
 # ChangeLog
 
+## [4.7.1] - 21-11-2021
+
+- feat: add `console.error` logging for errors thrown by provided app handler to help debugging.
+
 ## [4.7.0] - 21-11-2021
 
-- feat: Support Deno `1.16.2` and std `0.115.1` and other deps upgrades
+- feat: support Deno `1.16.2` and std `0.115.1` and other deps upgrades
 - fix: improved `Server` determination
 
 ## [4.6.1] - 05-11-2021

README.md

@@ -85,7 +85,7 @@ import { superdeno } from "https://deno.land/x/superdeno/mod.ts";
 SuperDeno is also available on [nest.land](https://nest.land/package/superdeno),
 a package registry for Deno on the Blockchain.
 
-> Note: All examples in this README are using the unversioned form of the import URL. In production you should always use the versioned import form such as `https://deno.land/x/superdeno@4.7.0/mod.ts`.
+> Note: All examples in this README are using the unversioned form of the import URL. In production you should always use the versioned import form such as `https://deno.land/x/superdeno@4.7.1/mod.ts`.
 
 ## Example
 

docs/index.html

@@ -143,7 +143,7 @@ <h2>Installation</h2>
 				<p>SuperDeno is also available on <a href="https://nest.land/package/superdeno">nest.land</a>,
 				a package registry for Deno on the Blockchain.</p>
 				<blockquote>
-					<p>Note: All examples in this README are using the unversioned form of the import URL. In production you should always use the versioned import form such as <code>https://deno.land/x/superdeno@4.7.0/mod.ts</code>.</p>
+					<p>Note: All examples in this README are using the unversioned form of the import URL. In production you should always use the versioned import form such as <code>https://deno.land/x/superdeno@4.7.1/mod.ts</code>.</p>
 				</blockquote>
 				<a href="#example" id="example" style="color: inherit; text-decoration: none;">
 					<h2>Example</h2>

egg.json

@@ -1,7 +1,7 @@
 {
   "name": "superdeno",
   "description": "HTTP assertions for Deno made easy via superagent.",
-  "version": "4.7.0",
+  "version": "4.7.1",
   "repository": "https://github.com/asos-craigmorten/superdeno",
   "stable": true,
   "checkFormat": false,

src/close.ts

@@ -29,13 +29,13 @@ export const close = async (
 
   if (serverErr) {
     console.error(
-      "SuperDeno experienced an unexpected server error",
+      "SuperDeno experienced an unexpected server error.",
       serverErr,
     );
   }
   if (error) {
     console.error(
-      "SuperDeno experienced an unexpected error closing the server",
+      "SuperDeno experienced an unexpected error closing the server.",
       error,
     );
   }

src/superdeno.ts

@@ -42,6 +42,17 @@ export interface SuperDeno {
   unsubscribe(url: string): Test;
 }
 
+async function startManagedServer(
+  managedServer: Server,
+  app: RequestHandlerLike,
+) {
+  try {
+    await managedServer.listenAndServe();
+  } catch (error) {
+    await close(managedServer, app, error);
+  }
+}
+
 /**
  * Takes a a url string, [`http.Server`](https://doc.deno.land/https/deno.land/std/http/mod.ts#Server),
  * a request handling function, or an object that implements an `app.listen()` method (which mirrors
@@ -66,11 +77,21 @@ export function superdeno(
   const obj: Record<string, any> = {};
 
   let managedServer: Server | undefined;
+
   if (!isString(app) && !isListener(app) && !isServer(app)) {
     managedServer = new Server({
       addr: ":0",
-      handler(request) {
-        return app(request);
+      async handler(request) {
+        try {
+          return await app(request);
+        } catch (error) {
+          console.error(
+            "SuperDeno experienced an unexpected server error with the underlying app handler.",
+            error,
+          );
+
+          throw error;
+        }
       },
     });
   }
@@ -87,14 +108,8 @@ export function superdeno(
     };
   });
 
-  if (isServer(managedServer)) {
-    (async () => {
-      try {
-        await managedServer.listenAndServe();
-      } catch (err) {
-        await close(managedServer, app, err);
-      }
-    })();
+  if (typeof managedServer !== "undefined") {
+    startManagedServer(managedServer, app as RequestHandlerLike);
   }
 
   return obj as SuperDeno;

src/xhrSham.js

@@ -228,8 +228,8 @@ export class XMLHttpRequestSham {
       this.statusText = "aborted";
     };
 
-    xhr.setErrorResponse = function () {
-      const errorMessage = this.message;
+    xhr.setErrorResponse = function (error) {
+      const errorMessage = this.message ?? error.message;
 
       // TODO: this needs work.
       //
@@ -324,13 +324,13 @@ export class XMLHttpRequestSham {
 
           return xhr.onreadystatechange();
         }
-      } catch (_) {
+      } catch (error) {
         // Error because it aborted
         if (this.aborted) {
           xhr.setAbortedResponse();
         } else {
           // Or genuine error
-          xhr.setErrorResponse();
+          xhr.setErrorResponse(error);
         }
 
         return xhr.onreadystatechange();

version.ts

@@ -1,7 +1,7 @@
 /**
  * Version of SuperDeno.
  */
-export const VERSION = "4.7.0";
+export const VERSION = "4.7.1";
 
 /**
  * Supported versions of Deno.