Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking if joint is in chain #141

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

joaomoura24
Copy link
Collaborator

@joaomoura24 joaomoura24 commented Jun 7, 2023

Description

Describe the additions made in this pull request.

Todo

  • Completed implementation of new feature.
  • Add documentation for the new feature.
  • Ensure all unit tests pass.
  • Address all issues raised by unit-tests.
  • Added code reviewer.

@cmower
Copy link
Owner

cmower commented Jun 7, 2023

I didn't check too much the code, but all the unit-tests are passing so the Jacobian should be computed correctly - perhaps we can add a unit test for dual arm (using the nextage) in a separate PR. If this solves @duISIR's issue then I'm happy for @joaomoura24 to merge directly.

@joaomoura24
Copy link
Collaborator Author

Ok, then I will go ahead and merge.
I'll add an issue for adding unit test for dual arm in case we want to start using more serious work on it, but not for the next month.

@joaomoura24 joaomoura24 merged commit a8aa7b1 into cmower:master Jun 7, 2023
10 checks passed
@joaomoura24 joaomoura24 deleted the fix-139 branch June 7, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants