Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #142 #154

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Fix #142 #154

merged 4 commits into from
Aug 11, 2023

Conversation

cmower
Copy link
Owner

@cmower cmower commented Aug 11, 2023

Description

Fix #142.

Todo

  • Completed implementation of new feature.
  • Add unit-test for the new feature.
  • Ensure all unit tests pass.
  • Address all issues raised by unit-tests.
  • Consider adding an example that demonstrates the use of the new feature.
  • Added code reviewer.

@cmower
Copy link
Owner Author

cmower commented Aug 11, 2023

@joaomoura24, I think this makes sense to just test a dual arm robot for FK against robotics toolbox for the same model (i.e. nextage).

Please let me know if you think we should add any other tests?

Otherwise, good to merge and close #142?

@joaomoura24
Copy link
Collaborator

Yeah, that 's ok - and to be honest I haven't found any issue so far with dual arm. I was just mentioning the lack of testing.
Ready to merge once you find fit.

@cmower cmower merged commit d844ec1 into master Aug 11, 2023
20 checks passed
@cmower cmower deleted the fix-142 branch August 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for dual arm robot.
2 participants