fix bug in extended seeding #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinnari
approved these changes
May 7, 2021
skinnari
pushed a commit
that referenced
this pull request
May 20, 2021
skinnari
pushed a commit
that referenced
this pull request
Jun 8, 2021
skinnari
pushed a commit
that referenced
this pull request
Jun 22, 2021
skinnari
pushed a commit
that referenced
this pull request
Jun 22, 2021
skinnari
pushed a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR makes the fix as described here. It fixes the extended tracking discarding prompt seeds. As a consequence of this fix, the efficiency at large eta increases.
PR validation:
When running extended on the prompt modules, you get back the same seeds saved and the same performance (efficiency and fake rate) as expected. Previously, the efficiency for extended on prompt modules was lower than for prompt tracking at high eta.