Allow ChannelCompatibilityCheck to skip channels with no signal templates #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks for this. We'll merge this shortly, but note that we don't anticipate a new combine release based on the 102x branch, instead developments are taking place on the 112x branch, where we've also ported this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #801 by skipping channels where the POI was not fitted due to missing signal templates in CRs. Also added a continue statement in FitterAlgoBase.cc to skip parameters which are not present also if the analytic minimiser is not used, to avoid a seg fault at RooRealVar &rf = dynamic_cast<RooRealVar &>(*rfloat); (I only encountered this issue with the latest versions of combine due to the switch of the default Minimizer from non-analytic to analytic). I haven't checked if this latter change affects other scripts, as I wasn't sure which tests to do, but can do some if requested.