uniform pdf for flat param #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ova/HiggsAnalysis-CombinedLimit into anigamova-uniform_pdf_for_flatParam
This allows the user to use parameters like `bkg_norm` and the option to create the flatParamPrior will pick it up
As part of PR, add info in docs for running limits
Fix issue in combineCards where DC parser misses new option, now set to default to avoid fault but nothing will happen to the output datacard
|
Still needs some work as logic is missing some types - ideally need to move the creation of prior outside of loop over nuisances... Will fix in next commit |
anigamova
reviewed
Apr 19, 2023
python/ModelTools.py
Outdated
| for flatNP in self.DC.toCreateFlatParam.items(): | ||
| c_param_name = flatNP[0] | ||
| c_param_details = flatNP[1] | ||
| print(c_param_name, c_param_details) |
There was a problem hiding this comment.
Probably this should be printed if verbose option is on or not printed at all?
|
Yes you're right, we should just comment this print out.
…On Wed, 19 Apr 2023, 15:08 Aliya Nigamova, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In python/ModelTools.py
<#834 (comment)>
:
> self.doObj("nuisancePdf", "PROD", ",".join(["%s_Pdf" % n for n in setNuisPdf]))
- self.doSet("globalObservables", ",".join(globalobs))
+ self.doSet("globalObservables", ",".join(self.globalobs))
+
+ def doAutoFlatNuisancePriors(self):
+ if len(self.DC.toCreateFlatParam.keys()) > 0:
+ for flatNP in self.DC.toCreateFlatParam.items():
+ c_param_name = flatNP[0]
+ c_param_details = flatNP[1]
+ print(c_param_name, c_param_details)
Probably this should be printed if verbose option is on or not printed at
all?
—
Reply to this email directly, view it on GitHub
<#834 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMEVW2GCMX7YJM6HPATDGTXB7WXLANCNFSM6AAAAAAWVJQSGU>
.
You are receiving this because you authored the thread.Message ID:
<cms-analysis/HiggsAnalysis-CombinedLimit/pull/834/review/1392161784@
github.com>
|
|
ok, fixed print out and ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the following PR #830 so should be merged after that one