Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex for floatNuisances #851

Merged
merged 5 commits into from Oct 10, 2023

Conversation

rkansal47
Copy link
Contributor

Solves #850.

@rkansal47 rkansal47 changed the title add regex for floatNuisances Add regex for floatNuisances Jul 19, 2023
Copy link
Collaborator

@kcormi kcormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice addition.

Since what is being done here is essentially a copy of what is already done for freezing the nuisance parameters (https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/Combine.cc#L607) it would be good not to repeat the code, and perhaps instead wrap this functionality in a function, which can then be called for both the floating and freezing case, just with a different set of arguments.

That would be nice for readability and making future changes less error prone.

I think it would also be good to add that this is done to the option description, as e.g. done for --trackParameters here: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/Combine.cc#L161

I'm not sure if it's really necessary, but perhaps we should also add a brief clause to the documentation:( https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/docs/part3/runningthetool.md?plain=1#L58) further stating that the same regex for freezeParameters applies for floatParameters.

Then I'd be happy to merge this in. Thanks!

@rkansal47
Copy link
Contributor Author

@kcormi Added, thanks! Let me know if there are any issues.

@kcormi
Copy link
Collaborator

kcormi commented Oct 10, 2023

Thanks @rkansal47, sorry for the slow reaction. I've decided to move the documentation so that it only gets updated with the next version, so that the documentation is for the officially recommended version. Thats in #866 and will be merged when we update the version.

@kcormi kcormi merged commit 97b5da4 into cms-analysis:main Oct 10, 2023
6 checks passed
@rkansal47 rkansal47 deleted the regex-float-parameters branch October 10, 2023 16:06
@nsmith- nsmith- linked an issue Nov 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--floatParameters doesn't accept regex
2 participants