Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update impact docs to explain multiple POI usage #852

Merged
merged 1 commit into from Jul 25, 2023
Merged

Update impact docs to explain multiple POI usage #852

merged 1 commit into from Jul 25, 2023

Conversation

ajgilbert
Copy link
Collaborator

As suggested here, this is really not obvious. This adds a few lines to the relevant docs.

@kcormi
Copy link
Collaborator

kcormi commented Jul 24, 2023

Thanks! Is it possible to also add a brief note on this for how --redefineSignalPOIs works here in the --help message for combineTool.py -M Impacts ? Maybe just to explain that it then handles the impacts for each POI separately, and that the order is important (at least should be consistent in various steps).

@ajgilbert
Copy link
Collaborator Author

Done! cms-analysis/CombineHarvester#304

@kcormi
Copy link
Collaborator

kcormi commented Jul 25, 2023

Great, thanks!

@kcormi kcormi merged commit cf9e6e6 into main Jul 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajgilbert @kcormi