Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UL 2017 scales and smearing txt files #8

Merged
merged 1 commit into from May 9, 2020

Conversation

jainshilpi
Copy link
Contributor

Committing the UL 2017 scales and smearings text files.

@cmsbuild
Copy link

cmsbuild commented May 8, 2020

A new Pull Request was created by @jainshilpi for branch master.

@cmsbuild, @smuzaffar, @santocch, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
@afiqaize, @Sam-Harper, @varuns23, @sobhatta this is something you requested to watch as well.
cms-bot commands are listed here

@slava77
Copy link

slava77 commented May 9, 2020

assign reconstruction
due to coupling to cms-sw/cmssw#29526

@cmsbuild
Copy link

cmsbuild commented May 9, 2020

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link

slava77 commented May 9, 2020

+1

since this just adds new files, the PR should be safe to merge as is.
Additionally, I tests with cms-sw/cmssw#29526, in workflows which actually use the new files, as described in cms-sw/cmssw#29526 (comment)

@cmsbuild
Copy link

cmsbuild commented May 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6195/console Started: 2020/05/09 07:51

@cmsbuild
Copy link

cmsbuild commented May 9, 2020

+1
Tested at: 29883f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b2bce/6195/summary.html
CMSSW: CMSSW_11_1_X_2020-05-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link

cmsbuild commented May 9, 2020

Comparison job queued.

@cmsbuild
Copy link

cmsbuild commented May 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b2bce/6195/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697168
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@santocch
Copy link

+1

@cmsbuild
Copy link

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants