Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference file for the unit test of RecoMTD/DetLayers with rounding at 4 decimal digits #9

Merged
merged 1 commit into from May 18, 2021

Conversation

fabiocos
Copy link
Contributor

In support of cms-sw/cmssw#33762

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-sw/cmssw#33762 for slc7_aarch4_gcc9

@fabiocos
Copy link
Contributor Author

please test with cms-sw/cmssw#33762 for slc7_ppc64le_gcc9

@fabiocos
Copy link
Contributor Author

the proposed fix works for ppc64le

@mrodozov
Copy link
Contributor

looks like it if the test doesn't fail, yes

@mrodozov
Copy link
Contributor

please test with cms-sw/cmssw#33762 for slc7_aarch64_gcc9

@mrodozov
Copy link
Contributor

please test with cms-sw/cmssw#33762 for slc7_aarch4_gcc9

a typo

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634853/15154/summary.html
COMMIT: 996a460
CMSSW: CMSSW_12_0_X_2021-05-17-2300/slc7_ppc64le_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Geometry-TestReference/9/15154/install.sh to create a dev area with all the needed externals and cmssw changes.

@fabiocos
Copy link
Contributor Author

@mrodozov it works also for aarch64

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634853/15159/summary.html
COMMIT: 996a460
CMSSW: CMSSW_12_0_X_2021-05-17-2300/slc7_aarch64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Geometry-TestReference/9/15159/install.sh to create a dev area with all the needed externals and cmssw changes.

@fabiocos
Copy link
Contributor Author

@mrodozov @silviodonato @qliphy please note that this PR without cms-sw/cmssw#33762 integrated in parallel will cause the unit test to fail also on amd64 (simply different numbers compared)

@fabiocos
Copy link
Contributor Author

ok, I see this has not yet been propagated to cmsdist cms-sw/cmsdist#6920

@fabiocos fabiocos deleted the fc-recomtdfix branch May 19, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants