Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEM-CSC slope correction LUTs #9

Merged
merged 2 commits into from Jun 21, 2021
Merged

GEM-CSC slope correction LUTs #9

merged 2 commits into from Jun 21, 2021

Conversation

rathjd
Copy link
Contributor

@rathjd rathjd commented May 20, 2021

Initial commit of GEM-CSC slope correction LUTs, using the slope values from the CSC ME1/1 chamber to shift the expected position on the facing GE1/1 chambers in phi in 1/8th strip coordinates in both hexadecimal and decimal versions. Further details in the amended README.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rathjd for branch master.

@smuzaffar, @mrodozov, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @dildick this is something you requested to watch as well.
cms-bot commands are listed here

@dildick
Copy link
Contributor

dildick commented May 27, 2021

@cecilecaillol Can this be merged?

@cecilecaillol
Copy link

please test

@cecilecaillol
Copy link

+l1

@dildick
Copy link
Contributor

dildick commented May 27, 2021

Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8b42/15365/summary.html
COMMIT: e4af8ef
CMSSW: CMSSW_12_0_X_2021-05-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-CSCTriggerPrimitives/9/15365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2650463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor

@dildick this are new files but is there anything usign them (cmssw) ?

@dildick
Copy link
Contributor

dildick commented Jun 1, 2021

The LUTs go in first. In a few weeks we will be putting in a PR with the code that uses them in the GEM-CSC integrated local trigger.

@dildick
Copy link
Contributor

dildick commented Jun 18, 2021

Hi, can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants