Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easy access to MC used to L1 track testing #2

Merged
merged 1 commit into from Jun 9, 2020
Merged

Provide easy access to MC used to L1 track testing #2

merged 1 commit into from Jun 9, 2020

Conversation

tomalin
Copy link
Contributor

@tomalin tomalin commented Apr 1, 2020

This provides easy access for interactive CMSSW jobs developing the L1 tracking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

A new Pull Request was created by @tomalin (Ian Tomalin) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
cms-bot commands are listed here

@smuzaffar smuzaffar mentioned this pull request Apr 13, 2020
@tomalin
Copy link
Contributor Author

tomalin commented May 12, 2020

Hi,
Is this PR waiting for anything?
Thanks,
Ian

@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

@smuzaffar
Copy link
Contributor

@tomalin , this looks good. It only has new files, so can be merged and included in IBs.
You do need to cleanup cms-sw/cmssw#29381 though to not have any ref of these files. Currently cms-sw/cmssw#29381 still have these files in the history . So I would suggest to squash the history to get rid of any ref to these data files.

@tomalin
Copy link
Contributor Author

tomalin commented Jun 8, 2020

cms-sw/cmssw#29381 has been merged. It needs the txt files from this PR, but this PR has not yet been merged. Is it waiting for anything?

@smuzaffar
Copy link
Contributor

@tomalin , if this was needed by cms-sw/cmssw#29381 then it should have been tested together. Any idea why tests and relvals are running fine in IB even without these files?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6895/console Started: 2020/06/09 09:30
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6896/console Started: 2020/06/09 09:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

+1
Tested at: d016d46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99ca57/6896/summary.html
CMSSW: CMSSW_11_2_X_2020-06-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99ca57/6896/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780403
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@rekovic
Copy link

rekovic commented Jun 11, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants