Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the sqlite DB for more complete L1 O2O unit tests #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

panoskatsoulis
Copy link
Contributor

The need for this updated file has been described in PR cms-sw/cmssw#37861 .
Extra PAYLOADs and IOVs have been added to the existing sqlite file to account for cases where part of the L1 keys have already been o2o'ed.

Tested this with the following steps:
Step 1)
Ran the 2 new L1O2O unit tests on vanilla 12_3_2 (where the issue first appear) with the failures below.

----- Begin Fatal Exception 01-Jun-2022 17:33:47 CEST-----------------------
An exception of category 'ConditionDatabase' occurred while
   [0] Processing  Event run: 4294967295 lumi: 1 event: 1 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module L1CondDBPayloadWriterExt/'L1CondDBPayloadWriterExt'
   [3] Calling method for EventSetup module L1TGlobalPrescalesVetosOnlineProd/''
Exception Message:
L1TGlobalPrescalesVetosFract for key ugt_pp/v1:ugt_rs_cosmics2020/v4 already in CondDB. 
----- End Fatal Exception -------------------------------------------------

Step 2)
Cherry picked the commit from the PR mentioned above and fixed the failures.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

A new Pull Request was created by @panoskatsoulis (Panos) for branch main.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@tvami
Copy link

tvami commented Jun 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/25169/summary.html
COMMIT: a46132f
CMSSW: CMSSW_12_5_X_2022-06-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1TriggerConfig-L1TConfigProducers/2/25169/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/25169/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/25169/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3649923
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3649893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link

tvami commented Jun 5, 2022

assign db

@tvami
Copy link

tvami commented Jun 5, 2022

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2022

New categories assigned: db

@ggovi,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@panoskatsoulis
Copy link
Contributor Author

@cecilecaillol or @epalencia
consider signing this

@cecilecaillol
Copy link

+l1

@smuzaffar
Copy link

+externals
@perrotta @qliphy cms-sw/cmssw#37861 has been merged, do we need these data files updates to go with cms-sw/cmssw#37861?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

@smuzaffar I read from cms-sw/cmssw#37861 (comment) that: the file in https://github.com/cms-data/L1TriggerConfig-L1TConfigProducers is meant to be updated too for better future testing.
and also here:
cms-sw/cmssw#37861 (comment)

So it should be good to go.

@cecilecaillol @panoskatsoulis Please confirm.

@tvami
Copy link

tvami commented Jun 10, 2022

I can confirm that's the plan

@smuzaffar
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/35771/summary.html
COMMIT: a46132f
CMSSW: CMSSW_14_0_X_2023-11-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1TriggerConfig-L1TConfigProducers/2/35771/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/35771/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25bf9/35771/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 99 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363028
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3363002
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants