Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tables for current MF versions #1

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Dec 5, 2019

These binary files contain reference values for regression tests of currently supported MF versions.

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

A new Pull Request was created by @namapane (Nicola Amapane) for branch master.

@perrotta, @smuzaffar, @cmsbuild, @mrodozov, @slava77 can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@slava77
Copy link

slava77 commented Dec 5, 2019

These binary files contain reference values for regression tests of currently supported MF versions.

@namapane
Please add a README.md or a similarly named file with a description of the content and the format of the binary files.
Thank you.

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

Pull request #1 was updated.

@slava77
Copy link

slava77 commented Dec 5, 2019

+1

@namapane
thank you for the quick update.

@smuzaffar @fabiocos
the PR looks in line with the earlier discussion by email. I think that we can merge it already.

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3833/console Started: 2019/12/05 18:40

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 3be1b54 into cms-data:master Dec 5, 2019
@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

Comparison job queued.

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71849f/3833/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799741
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link

fabiocos commented Dec 6, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants