Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lepton MVA weights for NanoAOD v5 and UL #5

Merged
merged 2 commits into from May 12, 2019

Conversation

peruzzim
Copy link
Contributor

@peruzzim peruzzim commented May 7, 2019

This PR contains new lepton MVA weights to be used in the next NanoAOD productions, in 10_2_X (v5) and 10_6_X (ultra-legacy).
Please switch both branches to use the updated version of this package, when merged.

@sscruz @fgolf @gpetruc

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

A new Pull Request was created by @peruzzim for branch master.

@smuzaffar, @santocch, @mrodozov, @cmsbuild, @fgolf, @gudrutis, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4936

@mrodozov
Copy link
Contributor

mrodozov commented May 7, 2019

assign analysis

@smuzaffar
Copy link
Contributor

@mrodozov , cms-bot now takes care of assigning the categories.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4937
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/51/console Started: 2019/05/07 14:17

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f0c85/51/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@peruzzim
Copy link
Contributor Author

peruzzim commented May 8, 2019

+xpog

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26703,cms-sw/cmssw#26672,cms-sw/cmsdist#4937
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/125/console Started: 2019/05/09 16:09

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e01a1/125/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 294 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211957
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211748
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.639 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): -0.639 KiB Physics/NanoAODDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link

+1

only new files added, the CMSSW PR is ready to be integrated, so I move forward with the integration of this

@fabiocos
Copy link

merge

@cmsbuild cmsbuild merged commit ebd125f into cms-data:master May 12, 2019
@smuzaffar
Copy link
Contributor

+externals

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild pushed a commit that referenced this pull request Mar 19, 2020
Updating b-jet regression weights with the latest recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants