Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SONIC structure for new ParticleNet and Higgs IN models + ONNX model update #53

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

wpmccormack
Copy link
Contributor

Companion PR to cms-sw/cmssw#43138. Adding required model structure and configuration files for SONIC implementation of ParticleNet (PN) from MiniAOD for Ak4 and Ak8 jets. Also including the Higgs Interaction network, as that is run through the same producer as PN. Structure of additions and use of symbolic links for model files was previous approved and used here: #48.

Tagging @kpedro88 @yongbinfeng @violatingcp

kpedro88 and others added 2 commits October 17, 2023 08:54
…Interaction Network. Same structure for SONIC as original versions of particlenet
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wpmccormack (Patrick McCormack) for branch master.

@jfernan2, @mandrenguyen, @cmsbuild, @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@wpmccormack to fix the runTheMatrix failures in cms-sw/cmssw#43138, you need to use the exact approach from #48: rather than making the file x.onnx a symlink, make a symlinked directory modelfile that points to ../../models/x/1 and then replace x.onnx with modelfile/model.onnx in the relevant CMSSW configs.

@cmsbuild
Copy link
Contributor

Pull request #53 was updated.

@wpmccormack
Copy link
Contributor Author

Ahh yes, sorry I've fixed that now

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit 9af440f into cms-data:master Nov 3, 2023
1 of 2 checks passed
@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants