Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of BDT based BH tagger training files #11

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

jainshilpi
Copy link
Contributor

First commit of the training files needed by the PR #36901

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

A new Pull Request was created by @jainshilpi for branch master.

@smuzaffar, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Sam-Harper, @valsdav, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #11 was updated.

@jpata
Copy link

jpata commented Feb 18, 2022

note: probably the .xml.gz file should be removed, and this PR rebased to erase it from history and keep the git repo size minimal.

@jpata
Copy link

jpata commented Mar 1, 2022

@jainshilpi could you please rebase this PR to remove the .xml.gz from history? just to keep the size minimal

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

Pull request #11 was updated.

@jainshilpi
Copy link
Contributor Author

@jainshilpi could you please rebase this PR to remove the .xml.gz from history? just to keep the size minimal

@jpata - sorry I meant to do it much before. Its done now. Thanks for the reminder.

@jpata
Copy link

jpata commented Mar 1, 2022

thanks, but this isn't fully correct: for the rebase, the commit history should contain only one commit, and it must be force pushed. Otherwise the deleted file still exists in git history.

See here "overview of rebase" for more details:
https://cms-sw.github.io/tutorial-resolve-conflicts.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

Pull request #11 was updated.

@jainshilpi
Copy link
Contributor Author

thanks, but this isn't fully correct: for the rebase, the commit history should contain only one commit, and it must be force pushed. Otherwise the deleted file still exists in git history.

See here "overview of rebase" for more details: https://cms-sw.github.io/tutorial-resolve-conflicts.html

I hope the last one takes care of removing this from the history as well. many thanks to @valsdav for helping with this.

@jpata
Copy link

jpata commented Mar 1, 2022

@cmsbuild please test with cms-sw/cmssw#36901

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc2ceb/22742/summary.html
COMMIT: 0705bf3
CMSSW: CMSSW_12_3_X_2022-03-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEgamma-PhotonIdentification/11/22742/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc2ceb/22742/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc2ceb/22742/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4000857
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4000827
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link

tvami commented Mar 3, 2022

@perrotta @qliphy I think this needs to be merged since cms-sw/cmssw#36901 was merged

@tvami
Copy link

tvami commented Mar 3, 2022

or @smuzaffar

it's currently stopping other PRs, see for example:
cms-sw/cmssw#37130 (comment)

@qliphy
Copy link

qliphy commented Mar 4, 2022

+1
tested with #36901

@qliphy
Copy link

qliphy commented Mar 4, 2022

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants