Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding low pt muon MVA (muon POG) #5

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

sscruz
Copy link

@sscruz sscruz commented Apr 15, 2019

Muon POG plans to add a new muons MVA targetting low pt muons. Details are being discussed in https://its.cern.ch/jira/browse/CMSMUONS-158.
PR to include the new selector in cmssw will follow shortly

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sscruz for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4880

@mrodozov
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link

slava77 commented Apr 15, 2019

@sscruz
the same questions as in #4 apply here to the file size:
the new files are a factor of 3 larger than the presently used mu_BDTG_Run2017.weights.xml.
Is is because the trees are larger? or is there something with the new format which may be a bit wasteful.

@sscruz
Copy link
Author

sscruz commented Apr 15, 2019

@slava77 indeed, the new BDT have a bit more trees (800 vs 1000), and each tree is also larger: we allow for a maximum depth of 4 instead of 2 now, and nodes with smaller size are allowed. It is expected that we have larger files then

@slava77
Copy link

slava77 commented Apr 15, 2019

I suggest to merge this with #4
This way we'll be able to test cms-sw/cmssw#26460 with the standard tools.

@mrodozov mrodozov merged commit 26a1712 into cms-data:master Apr 16, 2019
@slava77
Copy link

slava77 commented Apr 16, 2019

@mrodozov

sorry for not being clear in #5 (comment), I was making a comment to @sscruz asking to combine two PRs and address the comments in this one #4 (comment)

Based on the feedback so far, only the file renaming for the files introduced in #4 is missing.
So, a followup PR can be rather simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants