Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MLPF weight file #2

Merged
merged 1 commit into from Jan 7, 2021
Merged

add MLPF weight file #2

merged 1 commit into from Jan 7, 2021

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Nov 18, 2020

Needed for cms-sw/cmssw#32048.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for branch master.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@mmarionncern, @cbernet, @lgray, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test with cms-sw/cmssw#32048

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32048

@jpata
Copy link
Contributor Author

jpata commented Nov 18, 2020

please cancel

(I need to update the other PR too, there will be a new workflow)

@mrodozov
Copy link
Contributor

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@mrodozov
Copy link
Contributor

anyway, when it's ready you know how to start them both

@jpata
Copy link
Contributor Author

jpata commented Nov 18, 2020

yes, thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32048
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 1203c2f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10836/summary.html
CMSSW: CMSSW_11_2_X_2020-11-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #32166 @dan131riley: Fix use of LOCAL_TMP_DIR in unit tests
  • #32098 @mmusich: TkAlignment PV Validation tool: miscellaneous improvements
  • #32097 @bsunanda: Phase2-hgx268 Extending scintillator DetId to contain tile type c/m and SiPM type
  • #31744 @cms-tau-pog: Change DeepTauID modules so they can also process RECO input for HLT purposes
  • #32077 @mkirsano: Protect against empty weight container from pythia8
  • #32155 @makortel: Throw an exception in cms::cuda::chooseDevice() if CUDAService is disabled

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10836/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link

slava77 commented Nov 18, 2020

some README.md in mlpf/ or even in the main directory would be nice to summarize how the file was made and where it can be used.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10836/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8ed374/23234.13_TTbar_14TeV+2026D49_mlpf+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 22 failed jobs
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 24, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32048
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 1203c2f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10995/summary.html
CMSSW: CMSSW_11_2_X_2020-11-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ed374/10995/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8ed374/11834.13_TTbar_14TeV+2021PU_mlpf+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2961011
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960988
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@makortel
Copy link

makortel commented Jan 5, 2021

@silviodonato @qliphy This PR should probably be merged following the merge of cms-sw/cmssw#32048. The workflow added in #32048 (11834.13) is failing in IBs with

----- Begin Fatal Exception 05-Jan-2021 19:05:25 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MLPFProducer label='mlpfProducer'
Exception Message:
edm::FileInPath unable to find file RecoParticleFlow/PFProducer/data/mlpf/mlpf_2020_11_04.pb anywhere in the search path.

@qliphy
Copy link

qliphy commented Jan 6, 2021

@makortel Thanks for pointing this out.
@jpata Do you think this PR can be ready soon?

@jpata
Copy link
Contributor Author

jpata commented Jan 6, 2021

yes, this may be merged, sorry for not updating the PR description earlier.

@qliphy
Copy link

qliphy commented Jan 7, 2021

merge

@cmsbuild cmsbuild merged commit 0bf0c3a into cms-data:master Jan 7, 2021
@qliphy
Copy link

qliphy commented Jan 7, 2021

to fix the IB failure. Let's know if there is any concern from missing signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants