Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepcore barrel model 2017 #1

Merged
merged 1 commit into from Dec 17, 2020
Merged

deepcore barrel model 2017 #1

merged 1 commit into from Dec 17, 2020

Conversation

vberta
Copy link
Contributor

@vberta vberta commented Nov 25, 2020

Trained model for DeepCoreSeedGenerator, trained in 2019 on MC 2017. Barrel-only training.
for more info: https://twiki.cern.ch/twiki/bin/view/CMSPublic/NNJetCoreAtCtD2019
related to the PR: cms-sw/cmssw#32222

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32222
Test Parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vberta (Valerio Bertacchi) for branch main.

@perrotta, @smuzaffar, @jpata, @mrodozov, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: e18315e

CMSSW: CMSSW_11_2_X_2020-11-25-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-222794/11054/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
11723.17 step3

runTheMatrix-results/11723.17_QCD_Pt_1800_2400_14+2021_seedingDeepCore+QCD_Pt_1800_2400_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST/step3_QCD_Pt_1800_2400_14+2021_seedingDeepCore+QCD_Pt_1800_2400_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST.log

  • DAS Queries: The DAS query tests failed, see the summary page for details.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32222
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: e18315e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-222794/11064/summary.html
CMSSW: CMSSW_11_2_X_2020-11-25-2300
SCRAM_ARCH: slc7_amd64_gcc820
Additional comment: 'DAS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-222794/11064/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-222794/11723.17_QCD_Pt_1800_2400_14+2021_seedingDeepCore+QCD_Pt_1800_2400_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 1524
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2745466
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 35655.836 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 11624.911,... ): 8913.952 KiB Tracking/JetCore
  • DQMHistoSizes: changed ( 11624.911,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 11624.911,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 34 edm output root files, 36 DQM output files

@smuzaffar
Copy link

+externals

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 50e4882 into cms-data:main Dec 17, 2020
@silviodonato
Copy link
Contributor

@smuzaffar @mrodozov there is no cmsdist PR yet

@mrodozov
Copy link

mrodozov commented Dec 17, 2020

let me see if it has something to do with the 'main' branch regarding the master->main expected substitutes

@mrodozov
Copy link

yes, the job failed I need a sec to figure it how to put master OR main

@mrodozov
Copy link

@silviodonato fixed. its works also with main now

@silviodonato
Copy link
Contributor

@silviodonato fixed. its works also with main now

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants