Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testlib: backport fix for #1056 #1127

Merged
merged 1 commit into from Feb 10, 2021
Merged

testlib: backport fix for #1056 #1127

merged 1 commit into from Feb 10, 2021

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Aug 16, 2019

There is no newer stable testlib version, but we can backport the patch separately.

Fixes #1056. Upstream issue MikeMirzayanov/testlib#79.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1127 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   61.99%   61.97%   -0.03%     
==========================================
  Files         230      230              
  Lines       16604    16604              
==========================================
- Hits        10294    10290       -4     
- Misses       6310     6314       +4
Flag Coverage Δ
#functionaltests 45.68% <ø> (+0.08%) ⬆️
#unittests 43.27% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
cms/io/priorityqueue.py 92.7% <0%> (-2.19%) ⬇️
cms/service/ProxyService.py 57.44% <0%> (-1.6%) ⬇️
cms/server/admin/handlers/task.py 39.84% <0%> (-1.18%) ⬇️
cms/db/base.py 82.97% <0%> (-1.07%) ⬇️
cms/server/admin/handlers/dataset.py 25.07% <0%> (-0.62%) ⬇️
cms/io/service.py 68.9% <0%> (-0.61%) ⬇️
cms/server/contest/handlers/taskusertest.py 43.03% <0%> (-0.61%) ⬇️
cms/service/EvaluationService.py 67.55% <0%> (ø) ⬆️
cms/service/workerpool.py 61.66% <0%> (ø) ⬆️
cms/io/rpc.py 91.46% <0%> (+0.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9e92...3551241. Read the comment docs.

@andreyv andreyv merged commit 31599b6 into cms-dev:master Feb 10, 2021
@andreyv andreyv deleted the testlib-update branch February 10, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

check.cpp (checker) file not compiling because of testlib.h
1 participant