Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated std::auto_ptr with std::unique_ptr #8

Closed
wants to merge 0 commits into from
Closed

Replace deprecated std::auto_ptr with std::unique_ptr #8

wants to merge 0 commits into from

Conversation

guitargeek
Copy link
Contributor

This is to avoid getting flooded with deprecation warnings when
compiling this project.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for branch cms/CORAL_2_3_21py3.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44fd6f/22386/summary.html
COMMIT: d8516d4
CMSSW: CMSSW_12_3_X_2022-02-13-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/coral/8/22386/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

>> Entering Package LCG/MonitoringService
Entering library rule at LCG/MonitoringService
>> Entering Package LCG/ConnectionService
Entering library rule at LCG/ConnectionService
+ '[' '' == set ']'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.UYnY4R (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.UYnY4R (%build)

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44fd6f/22387/summary.html
COMMIT: d8516d4
CMSSW: CMSSW_12_3_X_2022-02-12-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/coral/8/22387/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/src/LCG/ConnectionService/src/WebCacheControl.cpp
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/boost/1.78.0-87d9f13f181dd2996465c6fdbf185bf9/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/libuuid/2.34-548af62999d8f41d39f61053ab3a9206/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/xerces-c/3.1.3-9b0a1c86bf32bf2d2a4e741871feb3e7/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable   -fPIC    -MMD -MF tmp/slc7_amd64_gcc11/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/src/LCG/ConnectionService/src/WebCacheControl.cpp -o tmp/slc7_amd64_gcc11/src/LCG/ConnectionService/src/lcg_ConnectionService/WebCacheControl.cpp.o
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/src/LCG/ConnectionService/src/SessionProxy.cpp
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/include/LCG -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/boost/1.78.0-87d9f13f181dd2996465c6fdbf185bf9/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/libuuid/2.34-548af62999d8f41d39f61053ab3a9206/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc11/external/xerces-c/3.1.3-9b0a1c86bf32bf2d2a4e741871feb3e7/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable   -fPIC    -MMD -MF tmp/slc7_amd64_gcc11/src/LCG/ConnectionService/src/lcg_ConnectionService/SessionProxy.cpp.d /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/794fe218dc09f6049b0fc8a745137672/opt/cmssw/slc7_amd64_gcc11/cms/coral/CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672/src/LCG/ConnectionService/src/SessionProxy.cpp -o tmp/slc7_amd64_gcc11/src/LCG/ConnectionService/src/lcg_ConnectionService/SessionProxy.cpp.o
+ '[' '' == set ']'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.uS3UBA (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+coral+CORAL_2_3_21-794fe218dc09f6049b0fc8a745137672
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.uS3UBA (%build)

@smuzaffar
Copy link
Contributor

the actual error is https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44fd6f/22386/cms/

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/973a816a4b50def02ff3fd8093933340/opt/cmssw/slc7_amd64_gcc10/cms/coral/CORAL_2_3_21-973a816a4b50def02ff3fd8093933340/src/LCG/OracleAccess/src/Cursor.cpp: In constructor 'coral::OracleAccess::Cursor::Cursor(std::unique_ptr<coral::OracleAccess::OracleStatement>, const coral::AttributeList&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/973a816a4b50def02ff3fd8093933340/opt/cmssw/slc7_amd64_gcc10/cms/coral/CORAL_2_3_21-973a816a4b50def02ff3fd8093933340/src/LCG/OracleAccess/src/Cursor.cpp:12:28: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = coral::OracleAccess::OracleStatement; _Dp = std::default_delete<coral::OracleAccess::OracleStatement>]'
   12 |   , m_rowBuffer( rowBuffer )
      |                            ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/include/c++/10.3.0/memory:83,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/973a816a4b50def02ff3fd8093933340/opt/cmssw/slc7_amd64_gcc10/cms/coral/CORAL_2_3_21-973a816a4b50def02ff3fd8093933340/src/LCG/OracleAccess/src/Cursor.h:4,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/973a816a4b50def02ff3fd8093933340/opt/cmssw/slc7_amd64_gcc10/cms/coral/CORAL_2_3_21-973a816a4b50def02ff3fd8093933340/src/LCG/OracleAccess/src/Cursor.cpp:6:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/include/c++/10.3.0/bits/unique_ptr.h:468:7: note: declared here
  468 |       unique_ptr(const unique_ptr&) = delete;
      |       ^~~~~~~~~~

@guitargeek guitargeek closed this Feb 14, 2022
@guitargeek guitargeek mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-started
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guitargeek @cmsbuild @smuzaffar