Fixed Physics List destruction #54

civanch · 2021-07-02T13:22:18Z

Address cms-sw issue #34271

cmsbuild · 2021-07-02T13:22:44Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch cms/v10.7.2.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

civanch · 2021-07-02T13:26:27Z

This PR needs extra commit - not yet ready for test.

cmsbuild · 2021-07-02T14:57:01Z

Pull request #54 was updated.

civanch · 2021-07-02T14:57:39Z

please test

smuzaffar · 2021-07-02T15:10:45Z

@civanch , by default bot will test it against normal 12.0.X IBs. Shouldn;t we test it against the special G4 Ibs?

smuzaffar · 2021-07-02T15:13:45Z

please test for CMSSW_12_0_G4VECGEOM_X

smuzaffar · 2021-07-02T15:14:45Z

please test for CMSSW_12_0_GEANT4_X

civanch · 2021-07-02T15:32:14Z

@smuzaffar , thanks! By the way, all 3 tests should pass (my expectation).

cmsbuild · 2021-07-02T17:46:32Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16419/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_X_2021-07-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16419/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_TrackerDetToDTCELinkCablingMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-02-1100/src/CondFormats/SiPhase2TrackerObjects/src/TrackerDetToDTCELinkCablingMap.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.

cmsbuild · 2021-07-02T18:00:03Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16420/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16420/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_SiPhase2OuterTrackerLorentzAngle.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/T_EventSetup_TrackerDetToDTCELinkCablingMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_G4VECGEOM_X_2021-07-01-2300/src/CondFormats/SiPhase2TrackerObjects/src/TrackerDetToDTCELinkCablingMap.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/SiPhase2TrackerObjects/src/CondFormatsSiPhase2TrackerObjects/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.

cmsbuild · 2021-07-02T19:01:05Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16421/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_GEANT4_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16421/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

ImportError: No module named clang.cindex
gmake: *** [tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc] Error 1
Entering library rule at CondFormats/GBRForest
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/CondFormatsGBRForest_xr.cc
>> Compiling  tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
c++: error: tmp/slc7_amd64_gcc900/src/CondFormats/GBRForest/src/CondFormatsGBRForest/a/Serialization.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.

civanch · 2021-07-03T18:00:11Z

@smuzaffar , I do not thing problem of the test connected with this PR, likely it is due to inconsistency of IB and this new branch.

smuzaffar · 2021-07-06T15:36:23Z

@civanch , yes we are changing a lot python packages this was due to missing llvm python2. This has been fixed now but there is no geant4 IB yet based on the latest externals. Let me build a geant4 IB so that we can test this PR

smuzaffar · 2021-07-06T21:47:39Z

please test

smuzaffar · 2021-07-06T21:50:05Z

please test for CMSSW_12_0_GEANT4_X

cmsbuild · 2021-07-07T05:39:03Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16514/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_GEANT4_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/54/16514/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 52047 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785924
DQMHistoTests: Total failures: 282593
DQMHistoTests: Total nulls: 232
DQMHistoTests: Total successes: 2503077
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -2.359 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.786 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 7.3 ): -1.120 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -1.493 KiB SiStrip/MechanicalView
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 14 / 37 workflows

cmsbuild · 2021-07-07T06:19:59Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16513/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/geant4/54/16513/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 51170 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785924
DQMHistoTests: Total failures: 284349
DQMHistoTests: Total nulls: 251
DQMHistoTests: Total successes: 2501302
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.23 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 13 / 37 workflows

civanch · 2021-07-07T06:59:44Z

@smuzaffar , there is no regression in several WFs. It seems not to be connected with this PR.

civanch · 2021-07-13T07:33:21Z

@smuzaffar , can test be restarted ?

smuzaffar · 2021-07-13T07:36:06Z

please test

cmsbuild · 2021-07-13T15:54:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16735/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 51168 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2787742
DQMHistoTests: Total failures: 284920
DQMHistoTests: Total nulls: 251
DQMHistoTests: Total successes: 2502571
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.23 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 13 / 37 workflows

civanch · 2021-07-13T16:58:09Z

@smuzaffar , I suspect that failed tests are not related to this PR.

smuzaffar · 2021-07-13T22:02:30Z

please test

cmsbuild · 2021-07-14T05:18:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf4a8a/16787/summary.html
COMMIT: 854b484
CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/geant4/54/16787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 51247 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 281776
DQMHistoTests: Total nulls: 248
DQMHistoTests: Total successes: 2504256
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.226 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 13 / 37 workflows

smuzaffar · 2021-07-14T07:02:57Z

@civanch , there are too many comparison failures. Do you understand those? were these expacted with this change?

civanch · 2021-07-14T07:40:48Z

@smuzaffar , this fix is only in the class destructor, so cannot affect run time. I suspect that problem is in what compared to what. This patch should be put on top of 10.7.2, if it is compared with the master, then we compare 10.7.1 and 10.7.2.

smuzaffar · 2021-07-14T07:57:47Z

yes we are currently comparing 10.7.1 with 10.7.2+patch. So how do you suggest we proceed? We get this in GEANT4 IB and then build geant4 release to validate 10.7.2?

civanch · 2021-07-14T08:29:18Z

@smuzaffar , yes, I think this PR can be merged to this 10.7.2 branch and it would be good to have a new IB 12_0_0_pre4_G410.7.2_VecGeom

cms-externals/geant4#54

fixed destruction

4c0b2d8

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Jul 2, 2021

take fix for patch only

854b484

cmsbuild added tests-started and removed tests-pending labels Jul 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 2, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 6, 2021

cmsbuild removed the tests-started label Jul 7, 2021

cmsbuild added the tests-rejected label Jul 7, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 13, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 13, 2021

cmsbuild added tests-started tests-approved and removed tests-approved tests-started labels Jul 13, 2021

cmsbuild added tests-started and removed tests-approved labels Jul 13, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 14, 2021

smuzaffar merged commit e32b281 into cms-externals:cms/v10.7.2 Jul 14, 2021

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Jul 14, 2021

[GEANT4][10.7.2] Fixed Physics List destruction

f4560af

cms-externals/geant4#54

smuzaffar mentioned this pull request Jul 14, 2021

[GEANT4][10.7.2] Fixed Physics List destruction cms-sw/cmsdist#7132

Merged

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Jul 14, 2021

[GEANT4][VECGEOM][10.7.2] Fixed Physics List destruction

1481ff7

cms-externals/geant4#54

smuzaffar mentioned this pull request Jul 14, 2021

[GEANT4][VECGEOM][10.7.2] Fixed Physics List destruction cms-sw/cmsdist#7133

Merged

smuzaffar mentioned this pull request Mar 16, 2023

Fixed warnings for LTO build of biglib #70

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Physics List destruction #54

Fixed Physics List destruction #54

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

civanch commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

civanch commented Jul 3, 2021

smuzaffar commented Jul 6, 2021

smuzaffar commented Jul 6, 2021

smuzaffar commented Jul 6, 2021

cmsbuild commented Jul 7, 2021

cmsbuild commented Jul 7, 2021

civanch commented Jul 7, 2021

civanch commented Jul 13, 2021

smuzaffar commented Jul 13, 2021

cmsbuild commented Jul 13, 2021

civanch commented Jul 13, 2021

smuzaffar commented Jul 13, 2021

cmsbuild commented Jul 14, 2021

smuzaffar commented Jul 14, 2021

civanch commented Jul 14, 2021

smuzaffar commented Jul 14, 2021

civanch commented Jul 14, 2021

Fixed Physics List destruction #54

Fixed Physics List destruction #54

Conversation

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

civanch commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

smuzaffar commented Jul 2, 2021

civanch commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

Build

cmsbuild commented Jul 2, 2021

Build

cmsbuild commented Jul 2, 2021

Build

civanch commented Jul 3, 2021

smuzaffar commented Jul 6, 2021

smuzaffar commented Jul 6, 2021

smuzaffar commented Jul 6, 2021

cmsbuild commented Jul 7, 2021

Unit Tests

Comparison Summary

cmsbuild commented Jul 7, 2021

Unit Tests

Comparison Summary

civanch commented Jul 7, 2021

civanch commented Jul 13, 2021

smuzaffar commented Jul 13, 2021

cmsbuild commented Jul 13, 2021

Comparison Summary

civanch commented Jul 13, 2021

smuzaffar commented Jul 13, 2021

cmsbuild commented Jul 14, 2021

Comparison Summary

smuzaffar commented Jul 14, 2021

civanch commented Jul 14, 2021

smuzaffar commented Jul 14, 2021

civanch commented Jul 14, 2021